<?xml version="1.0" encoding="utf-8"?>
<launchpad-bug id="712720">
  <date_last_updated>2011-05-10 23:14:19.593168+00:00</date_last_updated>
  <api_links>
    <bug_api_link>https://api.launchpad.net/1.0/bugs/712720</bug_api_link>
    <bug_owner_link>https://api.launchpad.net/1.0/~philip-stoev</bug_owner_link>
    <milestone_link>https://api.launchpad.net/1.0/maria/+milestone/5.3</milestone_link>
    <linked_branches_collection_link>https://api.launchpad.net/1.0/bugs/712720/linked_branches</linked_branches_collection_link>
    <activity_link>https://api.launchpad.net/1.0/bugs/712720/activity</activity_link>
  </api_links>
  <bug_web_link>https://bugs.launchpad.net/bugs/712720</bug_web_link>
  <owner>Philip Stoev</owner>
  <assignee>Michael Widenius</assignee>
  <milestone_title>Maria 5.3</milestone_title>
  <duplicate_link></duplicate_link>
  <duplicate_bug_id></duplicate_bug_id>
  <title>handlersocket does not compile against MariaDB 5.3</title>
  <status>Fix Released</status>
  <importance>Wishlist</importance>
  <created>2011-02-03 20:10:58.066289+00:00</created>
  <description>
<![CDATA[Even after working around bug 712714 , handlersocket does not compile against maria-5.3

To repeat, configure handlersocket

 ./configure --with-mysql-source=/home/philips/bzr/mysql-5.3.0-MariaDB-alpha --with-mysql-bindir=/home/philips/bzr/maria-5.3-bintar/bin/

then run "make" and you will get

/home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h: In member function ‘void dena::dbcontext::cmd_find_internal(dena::dbcallback_i&, const dena::prep_stmt&, ha_rkey_function, const dena::cmd_exec_args&)’:
/home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1805: error: ‘virtual int handler::index_read_map(uchar*, const uchar*, key_part_map, ha_rkey_function)’ is protected
database.cpp:793: error: within this context
/home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1823: error: ‘virtual int handler::index_prev(uchar*)’ is protected
database.cpp:798: error: within this context
/home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1821: error: ‘virtual int handler::index_next(uchar*)’ is protected
database.cpp:802: error: within this context
/home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1829: error: ‘virtual int handler::index_next_same(uchar*, const uchar*, uint)’ is protected
database.cpp:805: error: within this context
make[2]: *** [handlersocket_la-database.lo] Error 1]]>  </description>
  <activities>
    <activity datechanged="2011-02-03T20:10:58.066289+00:00">
      <oldvalue>
<![CDATA[]]>      </oldvalue>
      <newvalue>
<![CDATA[]]>      </newvalue>
      <whatchanged>bug</whatchanged>
      <person>Philip Stoev</person>
      <message>added bug</message>
    </activity>
    <activity datechanged="2011-02-03T20:11:04.582389+00:00">
      <oldvalue>
<![CDATA[]]>      </oldvalue>
      <newvalue>
<![CDATA[5.3]]>      </newvalue>
      <whatchanged>maria: milestone</whatchanged>
      <person>Philip Stoev</person>
      <message></message>
    </activity>
    <activity datechanged="2011-02-03T20:11:16.740347+00:00">
      <oldvalue>
<![CDATA[]]>      </oldvalue>
      <newvalue>
<![CDATA[lp:~maria-captains/maria/5.3-handler]]>      </newvalue>
      <whatchanged>branch linked</whatchanged>
      <person>Philip Stoev</person>
      <message></message>
    </activity>
    <activity datechanged="2011-02-08T09:34:34.822906+00:00">
      <oldvalue>
<![CDATA[]]>      </oldvalue>
      <newvalue>
<![CDATA[handlersocket.diff https://bugs.launchpad.net/maria/+bug/712720/+attachment/1837924/+files/handlersocket.diff]]>      </newvalue>
      <whatchanged>attachment added</whatchanged>
      <person>Sergei</person>
      <message></message>
    </activity>
    <activity datechanged="2011-02-08T09:35:17.870690+00:00">
      <oldvalue>
<![CDATA[]]>      </oldvalue>
      <newvalue>
<![CDATA[]]>      </newvalue>
      <whatchanged>bug</whatchanged>
      <person>Sergei</person>
      <message>added subscriber Sergei</message>
    </activity>
    <activity datechanged="2011-02-08T09:35:32.691015+00:00">
      <oldvalue>
<![CDATA[Undecided]]>      </oldvalue>
      <newvalue>
<![CDATA[Wishlist]]>      </newvalue>
      <whatchanged>maria: importance</whatchanged>
      <person>Sergei</person>
      <message></message>
    </activity>
    <activity datechanged="2011-02-08T09:35:36.639189+00:00">
      <oldvalue>
<![CDATA[New]]>      </oldvalue>
      <newvalue>
<![CDATA[Confirmed]]>      </newvalue>
      <whatchanged>maria: status</whatchanged>
      <person>Sergei</person>
      <message></message>
    </activity>
    <activity datechanged="2011-02-08T09:35:50.042211+00:00">
      <oldvalue>
<![CDATA[]]>      </oldvalue>
      <newvalue>
<![CDATA[Michael Widenius (monty)]]>      </newvalue>
      <whatchanged>maria: assignee</whatchanged>
      <person>Sergei</person>
      <message></message>
    </activity>
    <activity datechanged="2011-02-22T09:37:49.618671+00:00">
      <oldvalue>
<![CDATA[Confirmed]]>      </oldvalue>
      <newvalue>
<![CDATA[Fix Committed]]>      </newvalue>
      <whatchanged>maria: status</whatchanged>
      <person>Michael Widenius</person>
      <message></message>
    </activity>
    <activity datechanged="2011-05-10T23:14:19.093603+00:00">
      <oldvalue>
<![CDATA[Fix Committed]]>      </oldvalue>
      <newvalue>
<![CDATA[Fix Released]]>      </newvalue>
      <whatchanged>maria: status</whatchanged>
      <person>Michael Widenius</person>
      <message></message>
    </activity>
  </activities>
  <comments>
    <comment commentlink="https://api.launchpad.net/1.0/maria/+bug/712720/comments/1" datecreated="2011-02-03T21:11:31+00:00">
      <person>Sergei</person>
      <subject>
<![CDATA[Re: [Bug 712720] [NEW] handlersocket does not compile against	MariaDB 5.3]]>      </subject>
      <content>
<![CDATA[Hi, Philip!

we have a plug.in file for handlersocket that allows to build it from
within the source tree. It solves this problem.

On Feb 03, Philip Stoev wrote:
> Public bug reported:
> 
> Even after working around bug 712714 , handlersocket does not compile
> against maria-5.3
> 
> To repeat, configure handlersocket
> 
>  ./configure --with-mysql-source=/home/philips/bzr/mysql-5.3.0-MariaDB-
> alpha --with-mysql-bindir=/home/philips/bzr/maria-5.3-bintar/bin/
> 
> then run "make" and you will get
> 
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h: In member function ???void dena::dbcontext::cmd_find_internal(dena::dbcallback_i&, const dena::prep_stmt&, ha_rkey_function, const dena::cmd_exec_args&)???:
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1805: error: ???virtual int handler::index_read_map(uchar*, const uchar*, key_part_map, ha_rkey_function)??? is protected
> database.cpp:793: error: within this context
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1823: error: ???virtual int handler::index_prev(uchar*)??? is protected
> database.cpp:798: error: within this context
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1821: error: ???virtual int handler::index_next(uchar*)??? is protected
> database.cpp:802: error: within this context
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1829: error: ???virtual int handler::index_next_same(uchar*, const uchar*, uint)??? is protected
> database.cpp:805: error: within this context
> make[2]: *** [handlersocket_la-database.lo] Error 1
> 
> ** Affects: maria
>      Importance: Undecided
>          Status: New
> 
> ** Changed in: maria
>     Milestone: None => 5.3
> 
> ** Branch linked: lp:~maria-captains/maria/5.3-handler
> 
> -- 
> You received this bug notification because you are a member of Maria-
> captains, which is the registrant for Maria.
> https://bugs.launchpad.net/bugs/712720
> 
> Title:
>   handlersocket does not compile against MariaDB 5.3
> 
> Status in Maria:
>   New
> 
> Bug description:
>   Even after working around bug 712714 , handlersocket does not compile
>   against maria-5.3
> 
>   To repeat, configure handlersocket
> 
>    ./configure --with-mysql-source=/home/philips/bzr/mysql-5.3.0
>   -MariaDB-alpha --with-mysql-
>   bindir=/home/philips/bzr/maria-5.3-bintar/bin/
> 
>   then run "make" and you will get
> 
>   /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h: In member function ???void dena::dbcontext::cmd_find_internal(dena::dbcallback_i&, const dena::prep_stmt&, ha_rkey_function, const dena::cmd_exec_args&)???:
>   /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1805: error: ???virtual int handler::index_read_map(uchar*, const uchar*, key_part_map, ha_rkey_function)??? is protected
>   database.cpp:793: error: within this context
>   /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1823: error: ???virtual int handler::index_prev(uchar*)??? is protected
>   database.cpp:798: error: within this context
>   /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1821: error: ???virtual int handler::index_next(uchar*)??? is protected
>   database.cpp:802: error: within this context
>   /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1829: error: ???virtual int handler::index_next_same(uchar*, const uchar*, uint)??? is protected
>   database.cpp:805: error: within this context
>   make[2]: *** [handlersocket_la-database.lo] Error 1
> 
> 
> 
Regards,
Sergei
]]>      </content>
    </comment>
    <comment commentlink="https://api.launchpad.net/1.0/maria/+bug/712720/comments/2" datecreated="2011-02-04T09:07:39.680766+00:00">
      <person>Philip Stoev</person>
      <subject>
<![CDATA[Re: handlersocket does not compile against MariaDB 5.3]]>      </subject>
      <content>
<![CDATA[I think we should still provide a patch for the main handlersocket tree so that it compiles properly with MariaDB. ]]>      </content>
    </comment>
    <comment commentlink="https://api.launchpad.net/1.0/maria/+bug/712720/comments/3" datecreated="2011-02-08T09:34:34.822906+00:00">
      <person>Sergei</person>
      <subject>
<![CDATA[Re: handlersocket does not compile against MariaDB 5.3]]>      </subject>
      <content>
<![CDATA[plug.in file and all necessary changes]]>      </content>
    </comment>
    <comment commentlink="https://api.launchpad.net/1.0/maria/+bug/712720/comments/4" datecreated="2011-02-11T10:53:49.733294+00:00">
      <person>Philip Stoev</person>
      <subject>
<![CDATA[Re: handlersocket does not compile against MariaDB 5.3]]>      </subject>
      <content>
<![CDATA[Patch does not work against the latest handlersocket:


|diff -ru plugin/ahiguti-HandlerSocket-Plugin-for-MySQL-34cb96a/handlersocket/database.cpp plugin/HandlerSocket/handlersocket/database.cpp
|--- plugin/ahiguti-HandlerSocket-Plugin-for-MySQL-34cb96a/handlersocket/database.cpp   2011-01-01 23:59:13.000000000 +0100
|+++ plugin/HandlerSocket/handlersocket/database.cpp    2011-01-04 15:05:04.000000000 +0100
--------------------------
File to patch: handlersocket/database.cpp
patching file handlersocket/database.cpp
Hunk #1 succeeded at 790 (offset 11 lines).
patching file Makefile.am
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 7.
2 out of 2 hunks FAILED -- saving rejects to file Makefile.am.rej
patching file plug.in

]]>      </content>
    </comment>
    <comment commentlink="https://api.launchpad.net/1.0/maria/+bug/712720/comments/5" datecreated="2011-02-11T11:08:18.226661+00:00">
      <person>Philip Stoev</person>
      <subject>
<![CDATA[Re: handlersocket does not compile against MariaDB 5.3]]>      </subject>
      <content>
<![CDATA[nevermind it worked with -p2]]>      </content>
    </comment>
    <comment commentlink="https://api.launchpad.net/1.0/maria/+bug/712720/comments/6" datecreated="2011-02-11T12:42:19.536905+00:00">
      <person>Philip Stoev</person>
      <subject>
<![CDATA[Re: handlersocket does not compile against MariaDB 5.3]]>      </subject>
      <content>
<![CDATA[If -Werror is enabled, as it is by the ./BUILD/compile-pentium-debug-max-no-ndb script, we get:

(13:29:42) philip_stoev1: "cc1plus: warnings being treated as errors
(13:29:42) philip_stoev1: In file included from socket.hpp:15,
(13:29:42) philip_stoev1:                  from socket.cpp:18:
(13:29:42) philip_stoev1: auto_addrinfo.hpp: In member function ‘int dena::auto_addrinfo::resolve(const char*, const char*, int, int, int, int)’:
(13:29:42) philip_stoev1: auto_addrinfo.hpp:35: error: missing initializer for member ‘addrinfo::ai_flags’"]]>      </content>
    </comment>
    <comment commentlink="https://api.launchpad.net/1.0/maria/+bug/712720/comments/7" datecreated="2011-04-18T09:31:46.162735+00:00">
      <person>Jason</person>
      <subject>
<![CDATA[Re: handlersocket does not compile against MariaDB 5.3]]>      </subject>
      <content>
<![CDATA[Hi,

Where can I find the plug.in file and instructions on how to patch it.  I'm trying to build it against mariadb 5.2.5 and I am receiving the same error.

Thanks]]>      </content>
    </comment>
    <comment commentlink="https://api.launchpad.net/1.0/maria/+bug/712720/comments/8" datecreated="2011-04-18T17:39:04+00:00">
      <person>Sergei</person>
      <subject>
<![CDATA[Re: [Bug 712720] Re: handlersocket does not compile against	MariaDB 5.3]]>      </subject>
      <content>
<![CDATA[Hi, Jason!

On Apr 18, Jason wrote:
> Hi,
> 
> Where can I find the plug.in file and instructions on how to patch it.
> I'm trying to build it against mariadb 5.2.5 and I am receiving the same
> error.

See, the bug report has "Status: Fix Committed", and "Milestone: Maria 5.3".
Which means, you can find the files in 5.3 mariadb tree.

http://bazaar.launchpad.net/~maria-captains/maria/5.3/files

Regards,
Sergei
]]>      </content>
    </comment>
  </comments>
  <branches>
    <branch>lp:~maria-captains/maria/5.3-handler</branch>
  </branches>
  <messages>
    <message created="2011-02-08 09:34:34.822906+00:00" owner="Sergei">
<![CDATA[plug.in file and all necessary changes]]>      <attachment link="https://bugs.launchpad.net/bugs/712720/+attachment/1837924" type="Patch">
        <title>handlersocket.diff</title>
        <file>LPexportBug712720_handlersocket.diff</file>
      </attachment>
    </message>
  </messages>
</launchpad-bug>
